From 1e62523249b9837233367bfc37a82b03243c5b9f Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 4 May 2020 00:28:49 +0200 Subject: when tls verification is disabled for the feed, we should also disable this for the images --- internal/feed/mail.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/feed/mail.go b/internal/feed/mail.go index 5e308e2..3cb442e 100644 --- a/internal/feed/mail.go +++ b/internal/feed/mail.go @@ -7,6 +7,7 @@ import ( "io" "io/ioutil" "mime" + "net/http" "net/url" "path" "strings" @@ -192,8 +193,8 @@ func (feed *Feed) Messages() (msg.Messages, error) { return mails, nil } -func getImage(src string) ([]byte, string, error) { - resp, err := stdHTTPClient.Get(src) +func getImage(src string, client *http.Client) ([]byte, string, error) { + resp, err := client.Get(src) if err != nil { return nil, "", fmt.Errorf("fetching from '%s': %w", src, err) } @@ -277,7 +278,7 @@ func (item *item) buildBody() { } imgUrl := feedUrl.ResolveReference(srcUrl) - img, mime, err := getImage(imgUrl.String()) + img, mime, err := getImage(imgUrl.String(), httpClient(feed.NoTLS)) if err != nil { log.Errorf("Feed %s: Item %s: Error fetching image: %s", feed.Name, item.Item.Link, err) -- cgit v1.2.3-54-g00ecf