From 5d462ef47217c98b487bd6c1eaffb0630525ba92 Mon Sep 17 00:00:00 2001
From: René 'Necoro' Neumann <necoro@necoro.eu>
Date: Mon, 27 Apr 2020 16:48:55 +0200
Subject: Stylistic improvements

---
 internal/feed/parse.go | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/internal/feed/parse.go b/internal/feed/parse.go
index cc55581..539cad0 100644
--- a/internal/feed/parse.go
+++ b/internal/feed/parse.go
@@ -13,10 +13,16 @@ import (
 )
 
 // share HTTP clients
-var stdHTTPClient = &http.Client{Transport: http.DefaultTransport}
-var unsafeHTTPClient *http.Client
+var (
+	stdHTTPClient *http.Client
+    unsafeHTTPClient *http.Client
+)
 
 func init() {
+	// std
+	stdHTTPClient = &http.Client{Transport: http.DefaultTransport}
+	
+	// unsafe
 	tlsConfig := &tls.Config{InsecureSkipVerify: true}
 	transport := http.DefaultTransport.(*http.Transport).Clone()
 	transport.TLSClientConfig = tlsConfig
@@ -27,12 +33,11 @@ func context(timeout int) (ctxt.Context, ctxt.CancelFunc) {
 	return ctxt.WithTimeout(ctxt.Background(), time.Duration(timeout)*time.Second)
 }
 
-func setHTTPClient(parser *gofeed.Parser, disableTLS bool) {
+func httpClient(disableTLS bool) *http.Client {
 	if disableTLS {
-		parser.Client = unsafeHTTPClient
-	} else {
-		parser.Client = stdHTTPClient
+		return unsafeHTTPClient
 	}
+	return stdHTTPClient
 }
 
 func parseFeed(feed *Feed) error {
@@ -40,7 +45,7 @@ func parseFeed(feed *Feed) error {
 	defer cancel()
 
 	fp := gofeed.NewParser()
-	setHTTPClient(fp, *feed.NoTLS)
+	fp.Client = httpClient(*feed.NoTLS)
 
 	parsedFeed, err := fp.ParseURLWithContext(feed.Url, ctx)
 	if err != nil {
-- 
cgit v1.2.3-70-g09d2

mit/portato/waiting_queue.py?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25&amp;follow=1'>commit</a><a href='/portato.git/diff/portato/waiting_queue.py?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25&amp;follow=1'>diff</a></td><td class='form'><form class='right' method='get' action='/portato.git/log/portato/waiting_queue.py'>
<input type='hidden' name='h' value='v0.14'/><input type='hidden' name='id' value='edb012736afad95e069674fbe8ce9db192d39c25'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/portato.git/log/?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25&amp;follow=1'>root</a>/<a href='/portato.git/log/portato?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25&amp;follow=1'>portato</a>/<a href='/portato.git/log/portato/waiting_queue.py?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25&amp;follow=1'>waiting_queue.py</a> (<a href='/portato.git/log/portato/waiting_queue.py?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th></th><th class='left'>Commit message (<a href='/portato.git/log/portato/waiting_queue.py?h=v0.14&amp;id=edb012736afad95e069674fbe8ce9db192d39c25&amp;showmsg=1&amp;follow=1'>Expand</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>
<tr><td><span title='2009-08-15 15:19:01 +0200'>2009-08-15</span></td><td><a href='/portato.git/commit/extensions.sh?h=v0.14&amp;id=20f6015a96331575b3b402425f4c42eb91912cf1&amp;follow=1'>Enhanced the extensions.sh</a></td><td>René 'Necoro' Neumann</td><td>1</td><td><span class='deletions'>-3</span>/<span class='insertions'>+8</span></td></tr>
<tr><td><span title='2009-08-15 15:09:24 +0200'>2009-08-15</span></td><td><a href='/portato.git/commit/portato/eix/eix-format.html?h=v0.14&amp;id=e65b90763927ec9133f9b9c30e00b0a70b13b14b&amp;follow=1'>Move eix-format to correct location</a></td><td>René 'Necoro' Neumann</td><td>1</td><td><span class='deletions'>-0</span>/<span class='insertions'>+0</span></td></tr>