summaryrefslogtreecommitdiff
path: root/parsing.c
diff options
context:
space:
mode:
authorLars Hjemli <hjemli@gmail.com>2007-10-27 13:50:18 +0200
committerLars Hjemli <hjemli@gmail.com>2007-10-27 13:55:12 +0200
commitc61360fea0357672d2ab84a2c5a41ae1569f5d8a (patch)
treec0d55917537b1cbc8237ee63e3a1252abbdded40 /parsing.c
parent13d2b0b25cf19de03c7cdcf8bb708be1168aeda7 (diff)
downloadcgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.gz
cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.bz2
cgit-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.zip
cgit_parse_commit(): Add missing call to xstrdup()
It's rather silly to point into random memory-locations. Also, remove a call to strdup() used on a literal char *. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to '')
-rw-r--r--parsing.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/parsing.c b/parsing.c
index ddbafd5..30e7648 100644
--- a/parsing.c
+++ b/parsing.c
@@ -242,14 +242,14 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
t = strchr(p, '\n');
if (t) {
if (*t == '\0')
- ret->subject = strdup("** empty **");
+ ret->subject = "** empty **";
else
ret->subject = substr(p, t);
p = t + 1;
while (*p == '\n')
p = strchr(p, '\n') + 1;
- ret->msg = p;
+ ret->msg = xstrdup(p);
} else
ret->subject = substr(p, p+strlen(p));
from tree viewLars Hjemli6-13/+37 2007-05-13cgit v0.4v0.4Lars Hjemli1-1/+1 2007-05-13Add commitdiff between commit and each of it's parentLars Hjemli5-10/+63 2007-05-13Add graphical diffstat to commit viewLars Hjemli5-33/+130 2007-05-13Add max-commit-count parameter to cgitrcLars Hjemli4-2/+10 2007-05-13Show number of changed lines in log viewLars Hjemli1-1/+11 2007-05-13Simplify ui-diff.c using the new file-level diff interfaceLars Hjemli1-86/+2 2007-05-13Add standard interface for file diff functionsLars Hjemli2-0/+86 2007-05-13Show number of changed files in log viewLars Hjemli1-2/+15 2007-05-13Use standard tree-diff function when showing diffstat for single commitLars Hjemli1-51/+15 2007-05-13Add shared diff-handling functionsLars Hjemli2-2/+50 2007-05-12css: fix bad rendering in Internet ExplorerLars Hjemli1-2/+7 2007-05-11Add links to enable downloading of tagged blobsLars Hjemli2-9/+85 2007-05-11Makefile: add support for building w.o. preinstalled gitLars Hjemli1-1/+13 2007-05-11Tag release v0.3v0.3Lars Hjemli1-1/+1 2007-05-11Update README with submodule build infoLars Hjemli1-13/+39 2007-05-11Add submodule links in tree listingLars Hjemli6-12/+27 2007-05-11Add submodules.sh and use it during buildsLars Hjemli3-13/+222 2007-05-11Added git as a submoduleLars Hjemli2-1/+1 2007-05-09Add support for downloading single blobsLars Hjemli5-3/+47 2007-05-08ui-view: show pathname if specified in querystringLars Hjemli3-5/+10 2007-05-08Update to libgit 1.5.2-rc2Lars Hjemli9-837/+50 2007-02-21Layout updateLars Hjemli9-32/+127 2007-02-08Make snapshot feature configurableLars Hjemli5-6/+22 2007-02-08Add support for snapshotsLars Hjemli8-8/+153 2007-02-05cgit v0.2v0.2Lars Hjemli1-1/+1 2007-02-05Add support for prefix and gitsrc arguments to 'make'Lars Hjemli2-15/+37 2007-02-04Update cgitrc templateLars Hjemli1-21/+32 2007-02-04Add support for lightweight tagsLars Hjemli2-19/+37 2007-02-04Read repo-info from /etc/cgitrcLars Hjemli5-55/+120 2007-02-04Do not die if tag has no messageLars Hjemli1-2/+2 2007-02-03Fix search for non-virtual urlsLars Hjemli1-0/+6 2007-01-28Update README with install/config informationLars Hjemli1-24/+28