summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2011-02-28 12:18:57 +0100
committerLars Hjemli <hjemli@gmail.com>2011-03-05 13:38:34 +0100
commitfc384b16fb9787380746000d3cea2d53fccc548e (patch)
treed0a77d911c111e49904ab2f5061af22417f2b698 /tests
parent6bf2658f04089179aa373e47bd1d0718e808a59b (diff)
downloadcgit-fc384b16fb9787380746000d3cea2d53fccc548e.tar.gz
cgit-fc384b16fb9787380746000d3cea2d53fccc548e.tar.bz2
cgit-fc384b16fb9787380746000d3cea2d53fccc548e.zip
do not infloop on a query ending in %XY, for invalid hex X or Y
When a query ends in say %gg, (or any invalid hex) e.g., http://git.gnome.org/browse/gdlmm/commit/?id=%gg convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns txt-1, so the loop in http_parse_querystring never terminates. The solution is to make the memmove also copy the trailing NUL. * html.c (convert_query_hexchar): Fix off-by-one error. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions
Always #include corresponding .h in .c filesJohn Keeping22-8/+20 2013-04-08cgit.mk: fix dependency handlingJohn Keeping1-0/+8 2013-04-08Makefile: re-include cgit.conf in cgit.mkJohn Keeping1-0/+2 2013-04-08Do not unnecessarily strdup() environment variablesLukas Fleischer1-15/+10 2013-04-08Maŕk cgit_environment members constLukas Fleischer2-12/+12 2013-04-08Return const char * in cgit_{httpscheme, hosturl, rooturl}()Lukas Fleischer3-9/+9 2013-04-08Update git to v1.8.2.1John Keeping4-5/+6 2013-04-07ui-blob: don't segfault when no path is givenJohn Keeping1-1/+1 2013-03-20Convert pager navigation into a unordered listLukas Fleischer3-9/+20 2013-03-20Makefile: remove CGIT-CFLAGS files in clean stageJason A. Donenfeld1-1/+1 2013-03-20ui-summary.c: Move urls variable into print_urls()Lukas Fleischer1-6/+14 2013-03-20Fix colspan valuesLukas Fleischer3-14/+28 2013-03-20html: check return value of writeJason A. Donenfeld1-2/+3 2013-03-20ui-shared: squelch compiler warning.Jason A. Donenfeld1-0/+1 2013-03-20cgit.mk: Use SHELL_PATH_SQ to run gen-version.shJohn Keeping1-1/+1 2013-03-20cgit.mk: don't rebuild everything if CGIT_VERSION changesJohn Keeping1-1/+8 2013-03-20ui-patch: use cgit_version not CGIT_VERSIONJohn Keeping1-1/+1 2013-03-20Makefile: re-use Git's Makefile where possibleJohn Keeping3-119/+80