From b575115d9d93e45cdbcd5d066cc445d34639ae6a Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Sun, 5 Oct 2008 12:52:25 +0200 Subject: ui-shared.c: use html_url_arg() The link-generating functions are updated to use the new html_url_arg function, thereby fixing links to strange repos, branches and files. Also, the test-suite is updated to verify some cases of strange urls. Signed-off-by: Lars Hjemli --- ui-shared.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'ui-shared.c') diff --git a/ui-shared.c b/ui-shared.c index c23bc75..a2f636c 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -221,21 +221,21 @@ static char *repolink(char *title, char *class, char *page, char *head, } else { html(ctx.cfg.script_name); html("?url="); - html_attr(ctx.repo->url); + html_url_arg(ctx.repo->url); if (ctx.repo->url[strlen(ctx.repo->url) - 1] != '/') html("/"); if (page) { - html(page); + html_url_arg(page); html("/"); if (path) - html_attr(path); + html_url_arg(path); } delim = "&"; } if (head && strcmp(head, ctx.repo->defbranch)) { html(delim); html("h="); - html_attr(head); + html_url_arg(head); delim = "&"; } return fmt("%s", delim); @@ -250,7 +250,7 @@ static void reporevlink(char *page, char *name, char *title, char *class, if (rev && strcmp(rev, ctx.qry.head)) { html(delim); html("id="); - html_attr(rev); + html_url_arg(rev); } html("'>"); html_txt(name); @@ -278,17 +278,17 @@ void cgit_log_link(char *name, char *title, char *class, char *head, if (rev && strcmp(rev, ctx.qry.head)) { html(delim); html("id="); - html_attr(rev); + html_url_arg(rev); delim = "&"; } if (grep && pattern) { html(delim); html("qt="); - html_attr(grep); + html_url_arg(grep); delim = "&"; html(delim); html("q="); - html_attr(pattern); + html_url_arg(pattern); } if (ofs > 0) { html(delim); @@ -333,13 +333,13 @@ void cgit_diff_link(char *name, char *title, char *class, char *head, if (new_rev && strcmp(new_rev, ctx.qry.head)) { html(delim); html("id="); - html_attr(new_rev); + html_url_arg(new_rev); delim = "&"; } if (old_rev) { html(delim); html("id2="); - html_attr(old_rev); + html_url_arg(old_rev); } html("'>"); html_txt(name); -- cgit v1.2.3-70-g09d2 t>
Commit message (Expand)AuthorFilesLines
2007-04-25added systraynecoro6-20/+211
2007-04-25added noroot-optionnecoro7-11/+57
2007-04-24changed TODO and ChangeLognecoro2-1/+3
2007-04-24using (kde/gk)sunecoro2-2/+2
2007-04-24add application icon and desktop filenecoro1-2/+2
2007-04-24add application icon and desktop filenecoro7-4/+25
2007-04-24moved *.glade and *.ui to one directory to omit the change of the config.py e...necoro8-5/+2538
2007-04-24moved *.glade and *.ui to one directory to omit the change of the config.py e...necoro5-1191/+0
2007-04-24moved *.glade and *.ui to one directory to omit the change of the config.py e...necoro1-1340/+0
2007-04-24added dialogs to warn you when the queue is running on quitting portatonecoro8-214/+267
2007-04-20Made qt plugin-ready; lots of documentationnecoro15-81/+351
2007-04-18nomsgnecoro1-1/+0
2007-04-18finished Qt-Frontendnecoro5-15/+117
2007-04-17marking installed packages in pkglistnecoro5-14/+50
2007-04-16added ebuild window for Qt-Frontendnecoro4-2/+229
2007-04-16added preferences for Qt-Frontendnecoro9-279/+710
2007-04-13Improved masking display and made most of the Qt-Frontend worknecoro7-35/+334
2007-04-10Some more functionality for the Qt-Frontend (complete emerge)necoro8-217/+347
2007-04-07Some more functionality for the Qt-Frontendnecoro11-88/+463
2007-04-07Added Qt-Terminalnecoro4-4/+213
2007-04-06First qt draftnecoro6-1/+796
2007-04-04showed masked packages unmasked by the user similar to stable marked testing ...necoro5-13/+40
2007-03-31changed changelognecoro1-1/+2
2007-03-31Some small changes for etcproposals 1.1necoro1-2/+2
2007-03-31Some small changes for etcproposals 1.1necoro2-3/+3
2007-03-31Some small changes for etcproposals 1.1necoro1-6/+13
2007-03-31Allowed Plugins to have a menunecoro7-201/+315
2007-03-15Added etc-proposals pluginnecoro7-28/+121
2007-03-10Added USE_EXPAND-supportnecoro5-11/+63
2007-03-10Added plugin-data to about-dialognecoro3-197/+264