From 112973615a78ce61fd6e767128df03b075be72ca Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 14 Mar 2009 18:41:47 -0700 Subject: fix segfault when displaying empty blobs When size is zero, subtracting one from it turns it into ULONG_MAX which causes an out-of-bounds access on buf. Signed-off-by: Eric Wong Signed-off-by: Lars Hjemli --- ui-tree.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'ui-tree.c') diff --git a/ui-tree.c b/ui-tree.c index c6159ec..553dbaa 100644 --- a/ui-tree.c +++ b/ui-tree.c @@ -25,11 +25,14 @@ static void print_text_buffer(char *buf, unsigned long size) html("
");
 	idx = 0;
 	lineno = 0;
-	htmlf(numberfmt, ++lineno);
-	while(idx < size - 1) { // skip absolute last newline
-		if (buf[idx] == '\n')
-			htmlf(numberfmt, ++lineno);
-		idx++;
+
+	if (size) {
+		htmlf(numberfmt, ++lineno);
+		while(idx < size - 1) { // skip absolute last newline
+			if (buf[idx] == '\n')
+				htmlf(numberfmt, ++lineno);
+			idx++;
+		}
 	}
 	html("
\n"); html("
");
-- 
cgit v1.2.3-70-g09d2


Portato - A Portage GUIRené 'Necoro' Neumann


summaryrefslogtreecommitdiff









path: root/portato.py (unfollow)
Commit message (Collapse)AuthorFilesLines


2008-03-24Removed the nasty 'expand' bugRené 'Necoro' Neumann1-98/+98






2008-03-24Removed button labels in the package notebookRené 'Necoro' Neumann1-102/+96






2008-03-19install dbus_init pluginRené 'Necoro' Neumann1-1/+1






2008-03-19Init dbus threads using a pluginRené 'Necoro' Neumann3-1/+20






2008-03-19Make logger thread-safeRené 'Necoro' Neumann1-3/+6






2008-03-18Fixed new_use_flag creation errorRené 'Necoro' Neumann1-3/+3






2008-03-18keep i18n up2dateRené 'Necoro' Neumann3-326/+366






2008-03-18corrected header commentRené 'Necoro' Neumann1-2/+2






2008-03-18Removed gtk subdirRené 'Necoro' Neumann21-134/+79






2008-03-18Removed wrapperRené 'Necoro' Neumann2-238/+184






2008-03-18Split and renamed gui_helperRené 'Necoro' Neumann4-249/+266






2008-03-18Splitted windows.pyRené 'Necoro' Neumann10-424/+549






2008-03-12Moved get_dependencies to top package classRené 'Necoro' Neumann4-50/+85






2008-03-11improved performance by caching the use_expand queriesRené 'Necoro' Neumann1-5/+14






2008-03-11use catapult varsRené 'Necoro' Neumann2-4/+6






2008-03-11Updated catapult stuffRené 'Necoro' Neumann5-56/+108






2008-03-10Generate correct KeyNotFoundExceptionRené 'Necoro' Neumann1-2/+2






2008-03-09Small changesRené 'Necoro' Neumann3-1/+4






2008-03-07Better session handlingRené 'Necoro' Neumann1-5/+54






2008-03-07Small changesRené 'Necoro' Neumann1-1/+4






2008-03-07Updated shm module to 1.2René 'Necoro' Neumann1-8/+21






2008-03-07Update TODORené 'Necoro' Neumann1-3/+1






2008-03-07hmm ... yesRené 'Necoro' Neumann1-1/+1






2008-03-06Used better exceptions for configuration parserRené 'Necoro' Neumann1-26/+114






2008-03-06Update translationRené 'Necoro' Neumann2-349/+393






2008-03-06Update createpot.shRené 'Necoro' Neumann1-3/+2






2008-03-06Use 'nofork' instead of 'nolistener'René 'Necoro' Neumann1-3/+3






2008-03-05Install glade files into template dir and not data dirRené 'Necoro' Neumann2-2/+1






2008-03-05Added dependency listRené 'Necoro' Neumann3-117/+237