summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrupa <rupa@lrrr.us>2012-09-12 03:38:45 +0200
committerJason A. Donenfeld <Jason@zx2c4.com>2012-09-12 03:38:45 +0200
commit3a0c8bae77a15976f6b74ed92d57127f7d6cdca6 (patch)
treec7d68496f62ab2a4203849816f62a3e59fdfc8f2
parent6ecdfe3844eec6e3d3f2d04c506c75114d97a5ec (diff)
downloadpass-3a0c8bae77a15976f6b74ed92d57127f7d6cdca6.tar.gz
pass-3a0c8bae77a15976f6b74ed92d57127f7d6cdca6.tar.bz2
pass-3a0c8bae77a15976f6b74ed92d57127f7d6cdca6.zip
Don't quote ${EDITOR:-vi}
Attached is a trivial patch that removes the quotes from the line that invokes $EDITOR. It's perfectly cromulent to set $EDITOR to something with spaces in it, so when we evaluate this one we want it evaluated bare. For example security nerds might want EDITOR='vim -n' if they are scared of swap files, and that breaks if we quote there.
-rwxr-xr-xsrc/password-store.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/password-store.sh b/src/password-store.sh
index fe306b7..a89be8d 100755
--- a/src/password-store.sh
+++ b/src/password-store.sh
@@ -226,7 +226,7 @@ case "$command" in
fi
action="Edited"
fi
- "${EDITOR:-vi}" "$tmp_file"
+ ${EDITOR:-vi} "$tmp_file"
while ! gpg -q -e -r "$ID" -o "$passfile" --yes "$tmp_file"; do
echo "GPG encryption failed. Retrying."
sleep 1