From 4fa82cee8ca58d83902b351faa2742fd174c6fe5 Mon Sep 17 00:00:00 2001 From: Necoro <> Date: Tue, 18 Sep 2007 06:34:41 +0000 Subject: replaced some lists by generators to save memory --- portato/backend/portage/system.py | 4 ++-- portato/gui/gtk/windows.py | 4 ++-- portato/gui/gui_helper.py | 4 +--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/portato/backend/portage/system.py b/portato/backend/portage/system.py index eeccb9c..035425b 100644 --- a/portato/backend/portage/system.py +++ b/portato/backend/portage/system.py @@ -247,12 +247,12 @@ class PortageSystem (SystemInterface): return t def find_all_world_packages (self, name = None): - world = filter(self.find_lambda(name), [x.get_cpv() for x in self.find_world_packages()[0]]) + world = filter(self.find_lambda(name), (x.get_cpv() for x in self.find_world_packages()[0])) world = unique_array(world) return self.geneticize_list(world) def find_all_system_packages (self, name = None): - sys = filter(self.find_lambda(name), [x.get_cpv() for x in self.find_system_packages()[0]]) + sys = filter(self.find_lambda(name), (x.get_cpv() for x in self.find_system_packages()[0])) sys = unique_array(sys) return self.geneticize_list(sys) diff --git a/portato/gui/gtk/windows.py b/portato/gui/gtk/windows.py index 562624c..434381f 100644 --- a/portato/gui/gtk/windows.py +++ b/portato/gui/gtk/windows.py @@ -82,7 +82,7 @@ class PluginWindow (AbstractDialog): col = gtk.TreeViewColumn(_("Enabled"), bcell, active = 2) view.append_column(col) - for p in [(""+p.name+"", p.author, p.is_enabled()) for p in plugins]: + for p in ((""+p.name+"", p.author, p.is_enabled()) for p in plugins): self.store.append(p) self.window.show_all() @@ -580,7 +580,7 @@ class PackageTable: store = self.versList.get_model() # append versions - for vers, inst in [(x.get_version(), x.is_installed()) for x in self.packages]: + for vers, inst in ((x.get_version(), x.is_installed()) for x in self.packages): if inst: icon = self.main.instPixbuf else: diff --git a/portato/gui/gui_helper.py b/portato/gui/gui_helper.py index e1c9ce9..d1c53d0 100644 --- a/portato/gui/gui_helper.py +++ b/portato/gui/gui_helper.py @@ -201,9 +201,7 @@ class Database: # cycle through packages for p in packages: - list = p.split("/") - cat = list[0] - pkg = list[1] + cat, pkg = p.split("/") if not cat in self._db: self._db[cat] = [] self._db[cat].append((pkg, p in installed)) -- cgit v1.2.3-54-g00ecf