From 804606b721296a3dc6b4d386eaa3336ae772c9a2 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 12:45:01 +0100 Subject: First 'db' layout --- portato/db/__init__.py | 11 +++++++++++ portato/db/database.py | 42 ++++++++++++++++++++++++++++++++++++++++++ portato/gui/utils.py | 17 ----------------- 3 files changed, 53 insertions(+), 17 deletions(-) create mode 100644 portato/db/__init__.py create mode 100644 portato/db/database.py (limited to 'portato') diff --git a/portato/db/__init__.py b/portato/db/__init__.py new file mode 100644 index 0000000..5787c56 --- /dev/null +++ b/portato/db/__init__.py @@ -0,0 +1,11 @@ +# -*- coding: utf-8 -*- +# +# File: portato/db/__init__.py +# This file is part of the Portato-Project, a graphical portage-frontend. +# +# Copyright (C) 2009 René 'Necoro' Neumann +# This is free software. You may redistribute copies of it under the terms of +# the GNU General Public License version 2. +# There is NO WARRANTY, to the extent permitted by law. +# +# Written by René 'Necoro' Neumann diff --git a/portato/db/database.py b/portato/db/database.py new file mode 100644 index 0000000..7c51667 --- /dev/null +++ b/portato/db/database.py @@ -0,0 +1,42 @@ +# -*- coding: utf-8 -*- +# +# File: portato/db/database.py +# This file is part of the Portato-Project, a graphical portage-frontend. +# +# Copyright (C) 2009 René 'Necoro' Neumann +# This is free software. You may redistribute copies of it under the terms of +# the GNU General Public License version 2. +# There is NO WARRANTY, to the extent permitted by law. +# +# Written by René 'Necoro' Neumann + +class PkgData (object): + __slots__ = ("cat", "pkg", "inst") + + def __init__ (self, cat, pkg, inst): + self.cat = cat + self.pkg = pkg + self.inst = inst + + def __iter__ (self): + return iter((self.cat, self.pkg, self.inst)) + + def __cmp__ (self, other): + return cmp(self.pkg.lower(), other.pkg.lower()) + + def __repr__ (self): + return "" % {"cat" : self.cat, "pkg" : self.pkg, "inst" : self.inst} + +class Database (object): + + def populate (self, category = None): + raise NotImplentedError + + def get_cat (self, cat = None, byName = True): + raise NotImplentedError + + def get_categories (self, installed = False): + raise NotImplentedError + + def reload (self, cat = None): + raise NotImplentedError diff --git a/portato/gui/utils.py b/portato/gui/utils.py index d8af545..7f30269 100644 --- a/portato/gui/utils.py +++ b/portato/gui/utils.py @@ -157,23 +157,6 @@ class Config (ConfigParser): ConfigParser.write(self) self.modify_external_configs() -class PkgData (object): - __slots__ = ("cat", "pkg", "inst") - - def __init__ (self, cat, pkg, inst): - self.cat = cat - self.pkg = pkg - self.inst = inst - - def __iter__ (self): - return iter((self.cat, self.pkg, self.inst)) - - def __cmp__ (self, other): - return cmp(self.pkg.lower(), other.pkg.lower()) - - def __repr__ (self): - return "" % {"cat" : self.cat, "pkg" : self.pkg, "inst" : self.inst} - class DictDatabase (object): """An internal database which holds a simple dictionary cat -> [package_list].""" -- cgit v1.2.3-54-g00ecf From abbc143c81d9c5b808d5c8ee14acc33835871fd5 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 12:52:56 +0100 Subject: Moved DictDatabase --- portato/db/database.py | 28 +++++++++ portato/db/dict.py | 147 +++++++++++++++++++++++++++++++++++++++++++++ portato/gui/utils.py | 159 ------------------------------------------------- 3 files changed, 175 insertions(+), 159 deletions(-) create mode 100644 portato/db/dict.py (limited to 'portato') diff --git a/portato/db/database.py b/portato/db/database.py index 7c51667..0ff71a7 100644 --- a/portato/db/database.py +++ b/portato/db/database.py @@ -29,14 +29,42 @@ class PkgData (object): class Database (object): + ALL = _("ALL") + def populate (self, category = None): + """Populates the database. + + @param category: An optional category - so only packages of this category are inserted. + @type category: string + """ raise NotImplentedError def get_cat (self, cat = None, byName = True): + """Returns the packages in the category. + + @param cat: category to return the packages from; if None it defaults to C{ALL} + @type cat: string + @param byName: selects whether to return the list sorted by name or by installation + @type byName: boolean + @return: an iterator over the packages + @rtype: L{PkgData} + """ raise NotImplentedError def get_categories (self, installed = False): + """Returns all categories. + + @param installed: Only return these with at least one installed package. + @type installed: boolean + @returns: the list of categories + @rtype: string + """ raise NotImplentedError def reload (self, cat = None): + """Reloads the given category. + + @param cat: category + @type cat: string + """ raise NotImplentedError diff --git a/portato/db/dict.py b/portato/db/dict.py new file mode 100644 index 0000000..435cdd9 --- /dev/null +++ b/portato/db/dict.py @@ -0,0 +1,147 @@ +# -*- coding: utf-8 -*- +# +# File: portato/db/dict.py +# This file is part of the Portato-Project, a graphical portage-frontend. +# +# Copyright (C) 2009 René 'Necoro' Neumann +# This is free software. You may redistribute copies of it under the terms of +# the GNU General Public License version 2. +# There is NO WARRANTY, to the extent permitted by law. +# +# Written by René 'Necoro' Neumann + +from __future__ import absolute_import, with_statement + +import re +from collections import defaultdict +from functools import wraps + +from ..backend import system +from .database import Database, PkgData + +class DictDatabase (Database): + """An internal database which holds a simple dictionary cat -> [package_list].""" + + def __init__ (self): + """Constructor.""" + self.__initialize() + self._lock = RLock() + self.populate() + + def lock (f): + @wraps(f) + def wrapper (self, *args, **kwargs): + with self._lock: + r = f(self, *args, **kwargs) + return r + + return wrapper + + def __initialize (self): + self._db = defaultdict(list) + self.inst_cats = set([self.ALL]) + self._restrict = None + + def __sort_key (self, x): + return x.pkg.lower() + + @lock + def populate (self, category = None): + + # get the lists + packages = system.find_packages(category, with_version = False) + installed = system.find_packages(category, system.SET_INSTALLED, with_version = False) + + # cycle through packages + for p in packages: + cat, pkg = p.split("/") + inst = p in installed + t = PkgData(cat, pkg, inst) + self._db[cat].append(t) + self._db[self.ALL].append(t) + + if inst: + self.inst_cats.add(cat) + + for key in self._db: # sort alphabetically + self._db[key].sort(key = self.__sort_key) + + @lock + def get_cat (self, cat = None, byName = True): + if not cat: + cat = self.ALL + + def get_pkgs(): + if byName: + for pkg in self._db[cat]: + yield pkg + else: + ninst = [] + for pkg in self._db[cat]: + if pkg.inst: + yield pkg + else: + ninst.append(pkg) + + for pkg in ninst: + yield pkg + + try: + if self.restrict: + return (pkg for pkg in get_pkgs() if self.restrict.search(pkg.pkg))#if pkg[1].find(self.restrict) != -1) + else: + return get_pkgs() + + except KeyError: # cat is in category list - but not in portage + info(_("Catched KeyError => %s seems not to be an available category. Have you played with rsync-excludes?"), cat) + + @lock + def get_categories (self, installed = False): + if not self.restrict: + if installed: + cats = self.inst_cats + else: + cats = self._db.iterkeys() + + else: + if installed: + cats = set((pkg.cat for pkg in self.get_cat(self.ALL) if pkg.inst)) + else: + cats = set((pkg.cat for pkg in self.get_cat(self.ALL))) + + if len(cats)>1: + cats.add(self.ALL) + + return (cat for cat in cats) + + @lock + def reload (self, cat = None): + if cat: + del self._db[cat] + try: + self.inst_cats.remove(cat) + except KeyError: # not in inst_cats - can be ignored + pass + + self._db[self.ALL] = filter(lambda x: x.cat != cat, self._db[self.ALL]) + self.populate(cat+"/*") + else: + self.__initialize() + self.populate() + + def get_restrict (self): + return self._restrict + + @lock + def set_restrict (self, restrict): + if not restrict: + self._restrict = None + else: + try: + regex = re.compile(restrict, re.I) + except re.error, e: + info(_("Error while compiling search expression: '%s'."), str(e)) + else: # only set self._restrict if no error occurred + self._restrict = regex + + restrict = property(get_restrict, set_restrict) diff --git a/portato/gui/utils.py b/portato/gui/utils.py index 7f30269..2f30946 100644 --- a/portato/gui/utils.py +++ b/portato/gui/utils.py @@ -17,7 +17,6 @@ import re import sys, os import logging import gettext -from collections import defaultdict from threading import Thread, RLock from functools import wraps @@ -157,164 +156,6 @@ class Config (ConfigParser): ConfigParser.write(self) self.modify_external_configs() -class DictDatabase (object): - """An internal database which holds a simple dictionary cat -> [package_list].""" - - ALL = _("ALL") - - def __init__ (self): - """Constructor.""" - self.__initialize() - self._lock = RLock() - self.populate() - - def lock (f): - @wraps(f) - def wrapper (self, *args, **kwargs): - with self._lock: - r = f(self, *args, **kwargs) - return r - - return wrapper - - def __initialize (self): - self._db = defaultdict(list) - self.inst_cats = set([self.ALL]) - self._restrict = None - - def __sort_key (self, x): - return x.pkg.lower() - - @lock - def populate (self, category = None): - """Populates the database. - - @param category: An optional category - so only packages of this category are inserted. - @type category: string - """ - - # get the lists - packages = system.find_packages(category, with_version = False) - installed = system.find_packages(category, system.SET_INSTALLED, with_version = False) - - # cycle through packages - for p in packages: - cat, pkg = p.split("/") - inst = p in installed - t = PkgData(cat, pkg, inst) - self._db[cat].append(t) - self._db[self.ALL].append(t) - - if inst: - self.inst_cats.add(cat) - - for key in self._db: # sort alphabetically - self._db[key].sort(key = self.__sort_key) - - @lock - def get_cat (self, cat = None, byName = True): - """Returns the packages in the category. - - @param cat: category to return the packages from; if None it defaults to "ALL" - @type cat: string - @param byName: selects whether to return the list sorted by name or by installation - @type byName: boolean - @return: an iterator over a list of tuples: (category, name, is_installed) or [] - @rtype: (string, string, boolean) - """ - - if not cat: - cat = self.ALL - - def get_pkgs(): - if byName: - for pkg in self._db[cat]: - yield pkg - else: - ninst = [] - for pkg in self._db[cat]: - if pkg.inst: - yield pkg - else: - ninst.append(pkg) - - for pkg in ninst: - yield pkg - - try: - if self.restrict: - return (pkg for pkg in get_pkgs() if self.restrict.search(pkg.pkg))#if pkg[1].find(self.restrict) != -1) - else: - return get_pkgs() - - except KeyError: # cat is in category list - but not in portage - info(_("Catched KeyError => %s seems not to be an available category. Have you played with rsync-excludes?"), cat) - - @lock - def get_categories (self, installed = False): - """Returns all categories. - - @param installed: Only return these with at least one installed package. - @type installed: boolean - @returns: the list of categories - @rtype: string - """ - - if not self.restrict: - if installed: - cats = self.inst_cats - else: - cats = self._db.iterkeys() - - else: - if installed: - cats = set((pkg.cat for pkg in self.get_cat(self.ALL) if pkg.inst)) - else: - cats = set((pkg.cat for pkg in self.get_cat(self.ALL))) - - if len(cats)>1: - cats.add(self.ALL) - - return (cat for cat in cats) - - @lock - def reload (self, cat = None): - """Reloads the given category. - - @param cat: category - @type cat: string - """ - - if cat: - del self._db[cat] - try: - self.inst_cats.remove(cat) - except KeyError: # not in inst_cats - can be ignored - pass - - self._db[self.ALL] = filter(lambda x: x.cat != cat, self._db[self.ALL]) - self.populate(cat+"/*") - else: - self.__initialize() - self.populate() - - def get_restrict (self): - return self._restrict - - @lock - def set_restrict (self, restrict): - if not restrict: - self._restrict = None - else: - try: - regex = re.compile(restrict, re.I) - except re.error, e: - info(_("Error while compiling search expression: '%s'."), str(e)) - else: # only set self._restrict if no error occurred - self._restrict = regex - - restrict = property(get_restrict, set_restrict) - class SQLDatabase (object): ALL = _("ALL") -- cgit v1.2.3-54-g00ecf From 320f6f6270853b0209611ac6ec642994a90220b5 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 12:58:53 +0100 Subject: Moved SQLDatabase --- portato/db/database.py | 2 + portato/db/sql.py | 227 ++++++++++++++++++++++++++++++++++++++++++++ portato/gui/utils.py | 252 +------------------------------------------------ 3 files changed, 233 insertions(+), 248 deletions(-) create mode 100644 portato/db/sql.py (limited to 'portato') diff --git a/portato/db/database.py b/portato/db/database.py index 0ff71a7..7d8e378 100644 --- a/portato/db/database.py +++ b/portato/db/database.py @@ -10,6 +10,8 @@ # # Written by René 'Necoro' Neumann +from __future__ import absolute_import, with_statement + class PkgData (object): __slots__ = ("cat", "pkg", "inst") diff --git a/portato/db/sql.py b/portato/db/sql.py new file mode 100644 index 0000000..c80fd91 --- /dev/null +++ b/portato/db/sql.py @@ -0,0 +1,227 @@ +# -*- coding: utf-8 -*- +# +# File: portato/db/sql.py +# This file is part of the Portato-Project, a graphical portage-frontend. +# +# Copyright (C) 2009 René 'Necoro' Neumann +# This is free software. You may redistribute copies of it under the terms of +# the GNU General Public License version 2. +# There is NO WARRANTY, to the extent permitted by law. +# +# Written by René 'Necoro' Neumann + +from __future__ import absolute_import, with_statement + +try: + import sqlite3 as sql +except ImportError: + from pysqlite2 import dbapi2 as sql + +import anydbm +import hashlib +import os + +from functools import wraps +from threading import RLock + +from ..helper import info, error, debug +from ..backend import system +from .database import Database, PkgData + +class SQLDatabase (Database): + + FORBIDDEN = (".bzr", ".svn", ".git", "CVS", ".hg", "_darcs") + + def __init__ (self): + """Constructor.""" + self._restrict = "" + self._lock = RLock() + + pkgdb = os.path.join(SESSION_DIR, "package.db") + pkgdb_existed = os.path.exists(pkgdb) + + if pkgdb_existed: + debug("package.db already existant") + else: + debug("package.db not existant") + + pkg_conn = sql.connect(os.path.join(SESSION_DIR, "package.db")) + pkg_conn.row_factory = sql.Row + pkg_conn.execute(""" + CREATE TABLE IF NOT EXISTS packages + ( + name TEXT, + cat TEXT, + inst INTEGER + )""") + + pkg_conn.commit() + + self.was_updated = self.updated() + if self.was_updated or not pkgdb_existed: + info(_("Cleaning database...")) + pkg_conn.execute("DELETE FROM packages") # empty db at beginning + info(_("Populating database...")) + self.populate(connection = pkg_conn) + + pkg_conn.close() + + descr_conn = sql.connect(os.path.join(SESSION_DIR, "descr.db")) + descr_conn.execute(""" + CREATE TABLE IF NOT EXISTS descriptions + ( + cp TEXT, + descr TEXT + )""") + descr_conn.close() + + def updated (self): + changed = False + + def walk (path): + debug("Walking %s", path) + + for root, dirs, files in os.walk(path): + for f in files: + path = os.path.join(root, f) + yield "%s %s" % (f, os.stat(path).st_mtime) + + for forbidden in self.FORBIDDEN: + if forbidden in dirs: + dirs.remove(forbidden) + + overlays = system.get_global_settings("PORTDIR_OVERLAY").split() + hashes = {} + for overlay in overlays: + hashes[overlay] = hashlib.md5("".join(walk(overlay))).hexdigest() + + timestamp = os.path.join(system.get_global_settings("PORTDIR"), "metadata/timestamp") + hashes["ROOT"] = hashlib.md5("%s %s" % (timestamp, os.stat(timestamp).st_mtime)).hexdigest() + + dbpath = os.path.join(SESSION_DIR, "portdirs.db") + db_existed = os.path.exists(dbpath) + db = anydbm.open(dbpath, "c") + try: + if db_existed: + debug("portdirs.db already existant") + for key in set(db.keys())- set(hashes.keys()): + debug("Overlay '%s' has been removed", key) + del db[key] + changed = True + + for key in hashes.iterkeys(): + + if key not in db.keys(): + debug("Overlay '%s' has been added.", key) + changed = True + + elif db[key] != hashes[key]: + debug("Overlay '%s' has been changed.", key) + changed = True + + db[key] = hashes[key] + else: + debug("portdirs.db not existant") + for key in hashes.iterkeys(): + db[key] = hashes[key] + + finally: + db.close() + + return changed + + def lock (f): + @wraps(f) + def wrapper (self, *args, **kwargs): + with self._lock: + r = f(self, *args, **kwargs) + + return r + + return wrapper + + def con (f): + @wraps(f) + def wrapper (*args, **kwargs): + if not "connection" in kwargs: + con= sql.connect(os.path.join(SESSION_DIR, "package.db")) + con.row_factory = sql.Row + kwargs["connection"] = con + + return f(*args, **kwargs) + + return wrapper + + @lock + @con + def populate (self, category = None, connection = None): + def _get(): + # get the lists + inst = system.find_packages(pkgSet = system.SET_INSTALLED, key=category, with_version = False) + for p in system.find_packages(key = category, with_version = False): + cat, pkg = p.split("/") + + yield (cat, pkg, p in inst) + + connection.executemany("INSERT INTO packages (cat, name, inst) VALUES (?, ?, ?)", _get()) + connection.commit() + + @lock + @con + def get_cat (self, category = None, byName = True, connection = None): + sort = "ORDER BY name" + if not byName: + sort = "ORDER BY inst DESC, name" + + if not category or category == self.ALL: + c = connection.execute("SELECT cat, name, inst FROM packages WHERE 1=1 %s %s" % (self.restrict, sort)) + else: + c = connection.execute("SELECT cat, name, inst FROM packages WHERE cat = ? %s %s" % (self.restrict ,sort), (category,)) + + for pkg in c: + yield PkgData(pkg["cat"], pkg["name"], pkg["inst"]) + c.close() + + @lock + @con + def get_categories (self, installed = False, connection = None): + + if installed: + where = "inst = 1" + else: + where = "1 = 1" + + c = connection.execute("SELECT cat FROM packages WHERE %s %s GROUP BY cat" % (where, self.restrict)) + + l = c.fetchall() + c.close() + + if len(l) > 1: + yield self.ALL + + for cat in l: + yield cat["cat"] + + @lock + @con + def reload (self, cat = None, connection = None): + if cat: + connection.execute("DELETE FROM packages WHERE cat = ?", (cat,)) + connection.commit() + self.populate(cat+"/", connection = connection) + else: + connection.execute("DELETE FROM packages") + connection.commit() + self.populate(connection = connection) + + def get_restrict (self): + return self._restrict + + @lock + def set_restrict (self, restrict): + if not restrict: + self._restrict = "" + else: + self._restrict = "AND name LIKE '%%%s%%'" % restrict + + restrict = property(get_restrict, set_restrict) diff --git a/portato/gui/utils.py b/portato/gui/utils.py index 2f30946..c9eae69 100644 --- a/portato/gui/utils.py +++ b/portato/gui/utils.py @@ -13,28 +13,17 @@ from __future__ import absolute_import, with_statement # some stuff needed -import re -import sys, os +import sys import logging import gettext -from threading import Thread, RLock -from functools import wraps +from threading import Thread import gtk # some backend things -from ..backend import flags, system, set_system +from ..backend import flags, set_system from ..helper import debug, info, set_log_level -from ..constants import APP, LOCALE_DIR, USE_SQL, SESSION_DIR - -if USE_SQL: - try: - import sqlite3 as sql - except ImportError: - from pysqlite2 import dbapi2 as sql - - import anydbm - import hashlib +from ..constants import APP, LOCALE_DIR # parser from ..config_parser import ConfigParser @@ -155,236 +144,3 @@ class Config (ConfigParser): """Writes to the config file and modify any external configs.""" ConfigParser.write(self) self.modify_external_configs() - -class SQLDatabase (object): - - ALL = _("ALL") - FORBIDDEN = (".bzr", ".svn", ".git", "CVS", ".hg", "_darcs") - - def __init__ (self): - """Constructor.""" - self._restrict = "" - self._lock = RLock() - - pkgdb = os.path.join(SESSION_DIR, "package.db") - pkgdb_existed = os.path.exists(pkgdb) - - if pkgdb_existed: - debug("package.db already existant") - else: - debug("package.db not existant") - - pkg_conn = sql.connect(os.path.join(SESSION_DIR, "package.db")) - pkg_conn.row_factory = sql.Row - pkg_conn.execute(""" - CREATE TABLE IF NOT EXISTS packages - ( - name TEXT, - cat TEXT, - inst INTEGER - )""") - - pkg_conn.commit() - - self.was_updated = self.updated() - if self.was_updated or not pkgdb_existed: - info(_("Cleaning database...")) - pkg_conn.execute("DELETE FROM packages") # empty db at beginning - info(_("Populating database...")) - self.populate(connection = pkg_conn) - - pkg_conn.close() - - descr_conn = sql.connect(os.path.join(SESSION_DIR, "descr.db")) - descr_conn.execute(""" - CREATE TABLE IF NOT EXISTS descriptions - ( - cp TEXT, - descr TEXT - )""") - descr_conn.close() - - def updated (self): - changed = False - - def walk (path): - debug("Walking %s", path) - - for root, dirs, files in os.walk(path): - for f in files: - path = os.path.join(root, f) - yield "%s %s" % (f, os.stat(path).st_mtime) - - for forbidden in self.FORBIDDEN: - if forbidden in dirs: - dirs.remove(forbidden) - - overlays = system.get_global_settings("PORTDIR_OVERLAY").split() - hashes = {} - for overlay in overlays: - hashes[overlay] = hashlib.md5("".join(walk(overlay))).hexdigest() - - timestamp = os.path.join(system.get_global_settings("PORTDIR"), "metadata/timestamp") - hashes["ROOT"] = hashlib.md5("%s %s" % (timestamp, os.stat(timestamp).st_mtime)).hexdigest() - - dbpath = os.path.join(SESSION_DIR, "portdirs.db") - db_existed = os.path.exists(dbpath) - db = anydbm.open(dbpath, "c") - try: - if db_existed: - debug("portdirs.db already existant") - for key in set(db.keys())- set(hashes.keys()): - debug("Overlay '%s' has been removed", key) - del db[key] - changed = True - - for key in hashes.iterkeys(): - - if key not in db.keys(): - debug("Overlay '%s' has been added.", key) - changed = True - - elif db[key] != hashes[key]: - debug("Overlay '%s' has been changed.", key) - changed = True - - db[key] = hashes[key] - else: - debug("portdirs.db not existant") - for key in hashes.iterkeys(): - db[key] = hashes[key] - - finally: - db.close() - - return changed - - def lock (f): - @wraps(f) - def wrapper (self, *args, **kwargs): - with self._lock: - r = f(self, *args, **kwargs) - - return r - - return wrapper - - def con (f): - @wraps(f) - def wrapper (*args, **kwargs): - if not "connection" in kwargs: - con= sql.connect(os.path.join(SESSION_DIR, "package.db")) - con.row_factory = sql.Row - kwargs["connection"] = con - - return f(*args, **kwargs) - - return wrapper - - @lock - @con - def populate (self, category = None, connection = None): - """Populates the database. - - @param category: An optional category - so only packages of this category are inserted. - @type category: string - """ - - def _get(): - # get the lists - inst = system.find_packages(pkgSet = system.SET_INSTALLED, key=category, with_version = False) - for p in system.find_packages(key = category, with_version = False): - cat, pkg = p.split("/") - - yield (cat, pkg, p in inst) - - connection.executemany("INSERT INTO packages (cat, name, inst) VALUES (?, ?, ?)", _get()) - connection.commit() - - @lock - @con - def get_cat (self, category = None, byName = True, connection = None): - """Returns the packages in the category. - - @param cat: category to return the packages from; if None it defaults to "ALL" - @type cat: string - @param byName: selects whether to return the list sorted by name or by installation - @type byName: boolean - @return: an iterator over a list of tuples: (category, name, is_installed) or [] - @rtype: L{PkgData} - """ - - sort = "ORDER BY name" - if not byName: - sort = "ORDER BY inst DESC, name" - - if not category or category == self.ALL: - c = connection.execute("SELECT cat, name, inst FROM packages WHERE 1=1 %s %s" % (self.restrict, sort)) - else: - c = connection.execute("SELECT cat, name, inst FROM packages WHERE cat = ? %s %s" % (self.restrict ,sort), (category,)) - - for pkg in c: - yield PkgData(pkg["cat"], pkg["name"], pkg["inst"]) - c.close() - - @lock - @con - def get_categories (self, installed = False, connection = None): - """Returns all categories. - - @param installed: Only return these with at least one installed package. - @type installed: boolean - @returns: the list of categories - @rtype: string - """ - - if installed: - where = "inst = 1" - else: - where = "1 = 1" - - c = connection.execute("SELECT cat FROM packages WHERE %s %s GROUP BY cat" % (where, self.restrict)) - - l = c.fetchall() - c.close() - - if len(l) > 1: - yield self.ALL - - for cat in l: - yield cat["cat"] - - @lock - @con - def reload (self, cat = None, connection = None): - """Reloads the given category. - - @param cat: category - @type cat: string - """ - - if cat: - connection.execute("DELETE FROM packages WHERE cat = ?", (cat,)) - connection.commit() - self.populate(cat+"/", connection = connection) - else: - connection.execute("DELETE FROM packages") - connection.commit() - self.populate(connection = connection) - - def get_restrict (self): - return self._restrict - - @lock - def set_restrict (self, restrict): - if not restrict: - self._restrict = "" - else: - self._restrict = "AND name LIKE '%%%s%%'" % restrict - - restrict = property(get_restrict, set_restrict) - -if USE_SQL: - Database = SQLDatabase -else: - Database = DictDatabase -- cgit v1.2.3-54-g00ecf From 816fbaf42407fbbb8466c0d08d64fc11f605e5b6 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 13:13:56 +0100 Subject: Use the new database class layout --- portato/db/__init__.py | 14 ++++++++++++++ portato/db/database.py | 17 +++++++++++++++++ portato/db/dict.py | 16 +++++----------- portato/db/sql.py | 16 ++++------------ portato/gui/windows/main.py | 3 ++- 5 files changed, 42 insertions(+), 24 deletions(-) (limited to 'portato') diff --git a/portato/db/__init__.py b/portato/db/__init__.py index 5787c56..122940a 100644 --- a/portato/db/__init__.py +++ b/portato/db/__init__.py @@ -9,3 +9,17 @@ # There is NO WARRANTY, to the extent permitted by law. # # Written by René 'Necoro' Neumann + +from __future__ import absolute_import + +from ..constants import USE_SQL +from ..helper import debug + +if USE_SQL: + debug("Using SQLDatabase") + from .sql import SQLDatabase + Database = SQLDatabase +else: + debug("Using DictDatabase") + from .dict import DictDatabase + Database = DictDatabase diff --git a/portato/db/database.py b/portato/db/database.py index 7d8e378..941c3a3 100644 --- a/portato/db/database.py +++ b/portato/db/database.py @@ -12,6 +12,9 @@ from __future__ import absolute_import, with_statement +from threading import RLock +from functools import wraps + class PkgData (object): __slots__ = ("cat", "pkg", "inst") @@ -33,6 +36,20 @@ class Database (object): ALL = _("ALL") + def __init__ (self): + self._lock = RLock() + + @staticmethod + def lock (f): + @wraps(f) + def wrapper (self, *args, **kwargs): + with self._lock: + r = f(self, *args, **kwargs) + + return r + + return wrapper + def populate (self, category = None): """Populates the database. diff --git a/portato/db/dict.py b/portato/db/dict.py index 435cdd9..5c5ca49 100644 --- a/portato/db/dict.py +++ b/portato/db/dict.py @@ -14,7 +14,7 @@ from __future__ import absolute_import, with_statement import re from collections import defaultdict -from functools import wraps +from threading import RLock from ..backend import system from .database import Database, PkgData @@ -22,21 +22,15 @@ from .database import Database, PkgData class DictDatabase (Database): """An internal database which holds a simple dictionary cat -> [package_list].""" + lock = Database.lock + def __init__ (self): """Constructor.""" + Database.__init__(self) + self.__initialize() - self._lock = RLock() self.populate() - def lock (f): - @wraps(f) - def wrapper (self, *args, **kwargs): - with self._lock: - r = f(self, *args, **kwargs) - return r - - return wrapper - def __initialize (self): self._db = defaultdict(list) self.inst_cats = set([self.ALL]) diff --git a/portato/db/sql.py b/portato/db/sql.py index c80fd91..e7be91e 100644 --- a/portato/db/sql.py +++ b/portato/db/sql.py @@ -22,8 +22,8 @@ import hashlib import os from functools import wraps -from threading import RLock +from ..constants import SESSION_DIR from ..helper import info, error, debug from ..backend import system from .database import Database, PkgData @@ -31,11 +31,13 @@ from .database import Database, PkgData class SQLDatabase (Database): FORBIDDEN = (".bzr", ".svn", ".git", "CVS", ".hg", "_darcs") + lock = Database.lock def __init__ (self): """Constructor.""" + Database.__init__(self) + self._restrict = "" - self._lock = RLock() pkgdb = os.path.join(SESSION_DIR, "package.db") pkgdb_existed = os.path.exists(pkgdb) @@ -130,16 +132,6 @@ class SQLDatabase (Database): return changed - def lock (f): - @wraps(f) - def wrapper (self, *args, **kwargs): - with self._lock: - r = f(self, *args, **kwargs) - - return r - - return wrapper - def con (f): @wraps(f) def wrapper (*args, **kwargs): diff --git a/portato/gui/windows/main.py b/portato/gui/windows/main.py index 0882c2a..b8d3c17 100644 --- a/portato/gui/windows/main.py +++ b/portato/gui/windows/main.py @@ -26,11 +26,12 @@ from ...backend import flags, system # must be the first to avoid circular deps from ... import get_listener, plugin from ...helper import debug, warning, error, info, unique_array from ...session import Session +from ...db import Database from ...constants import CONFIG_LOCATION, VERSION, APP_ICON, ICON_DIR from ...backend.exceptions import PackageNotFoundException, BlockedException # more GUI stuff -from ..utils import Database, Config, GtkThread, get_color +from ..utils import Config, GtkThread, get_color from ..queue import EmergeQueue from ..session import SESSION_VERSION, SessionException, OldSessionException, NewSessionException from ..wrapper import GtkTree, GtkConsole -- cgit v1.2.3-54-g00ecf From 2a5e9163052e607e509da61c674502cad30de65c Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 15:40:50 +0100 Subject: Add a global session list --- portato/gui/windows/main.py | 4 ++-- portato/session.py | 21 ++++++++++++++++++--- 2 files changed, 20 insertions(+), 5 deletions(-) (limited to 'portato') diff --git a/portato/gui/windows/main.py b/portato/gui/windows/main.py index 0882c2a..d66ca0c 100644 --- a/portato/gui/windows/main.py +++ b/portato/gui/windows/main.py @@ -1826,8 +1826,8 @@ class MainWindow (Window): self.__save_queue = (ret == gtk.RESPONSE_YES) self.queue.kill_emerge() - # write session - self.session.save() + # write sessions + Session.close() return False diff --git a/portato/session.py b/portato/session.py index cd4737e..0bafee2 100644 --- a/portato/session.py +++ b/portato/session.py @@ -18,6 +18,8 @@ from .config_parser import ConfigParser, SectionNotFoundException from .constants import SESSION_DIR from .helper import debug, info +sessionlist = [] + class Session (object): """ A small class allowing to save certain states of a program. @@ -31,13 +33,14 @@ class Session (object): # the current session format version VERSION = 1 - def __init__ (self, file, name="", oldfiles = []): + def __init__ (self, file, name="", oldfiles = [], register = True): """ Initialize a session with a certain file inside L{SESSION_DIR}. @param file: the file in L{SESSION_DIR}, where the options will be saved. @param oldfiles: old file names for the same file @param name: short name describing the type of session + @param register: register in the global sessionlist, which is closed at the end """ self._cfg = None @@ -60,9 +63,9 @@ class Session (object): self._cfg = ConfigParser(file) if name: - i = _("Loading '%s' session from '%s'.") % (name, self._cfg.file) + i = _("Loading '%s' session from %s.") % (name, self._cfg.file) else: - i = _("Loading session from '%s'.") % self._cfg.file + i = _("Loading session from %s.") % self._cfg.file info(i) @@ -72,6 +75,9 @@ class Session (object): if e.errno == 2: pass else: raise + # register + if register: sessionlist.append(self) + # add version check self.add_handler(([("version", "session")], self.check_version, lambda: self.VERSION)) @@ -127,6 +133,15 @@ class Session (object): self._cfg.write() + @classmethod + def close (cls): + for s in sessionlist: + if s._name != "MAIN": + info(_("Saving '%s' session to %s.") % (s._name, s._cfg.file)) + else: + info(_("Saving session to %s.") % s._cfg.file) + s.save() + def set (self, key, value, section = ""): if not section: section = self._name -- cgit v1.2.3-54-g00ecf From 1f25c87bad1ffcbe7708a3126c9465fba6644fe5 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 16:04:32 +0100 Subject: Add a SectionDict class, which maps a section of a session to a dict. --- portato/session.py | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'portato') diff --git a/portato/session.py b/portato/session.py index 0bafee2..76e5540 100644 --- a/portato/session.py +++ b/portato/session.py @@ -13,6 +13,7 @@ from __future__ import absolute_import, with_statement import os, os.path +from UserDict import DictMixin from .config_parser import ConfigParser, SectionNotFoundException from .constants import SESSION_DIR @@ -208,3 +209,29 @@ class Session (object): def check_version (self, vers): pass # do nothing atm + +class SectionDict (DictMixin): + """A class, which maps a specific section of a session to a dictionary.""" + + def __init__ (self, session, section): + self._section = section.upper() + self._session = session + + def __getitem__ (self, name): + item = self._session.get(name, section = self._section) + + if item is None: + raise KeyError, "%s not in section %s" % (name, self._section) + return item + + def __setitem__ (self, name, value): + self._session.set(name, value, section = self._section) + + def __delitem__ (self, name): + self._session.remove(name, self._section) + + def keys (self): + return self._session._cfg.vars[self._section].keys() + + def __contains__ (self, name): + return self._session.get(name, self._section) is not None -- cgit v1.2.3-54-g00ecf From 59792e7297d90cdead2e1c83e4537991b20dd11c Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Wed, 28 Jan 2009 22:27:59 +0100 Subject: Enable sql-db formats --- portato/db/__init__.py | 25 +++++++++++++++++-------- portato/db/dict.py | 3 ++- portato/db/sql.py | 21 ++++++++++++++++----- 3 files changed, 35 insertions(+), 14 deletions(-) (limited to 'portato') diff --git a/portato/db/__init__.py b/portato/db/__init__.py index 122940a..40bf9ee 100644 --- a/portato/db/__init__.py +++ b/portato/db/__init__.py @@ -12,14 +12,23 @@ from __future__ import absolute_import +from ..session import Session, SectionDict from ..constants import USE_SQL from ..helper import debug -if USE_SQL: - debug("Using SQLDatabase") - from .sql import SQLDatabase - Database = SQLDatabase -else: - debug("Using DictDatabase") - from .dict import DictDatabase - Database = DictDatabase +_SESSION = None + +def Database(): + global _SESSION + + if _SESSION is None: + _SESSION = Session("db.cfg", name = "DB") + + if USE_SQL: + debug("Using SQLDatabase") + from .sql import SQLDatabase + return SQLDatabase(SectionDict(_SESSION, "SQL")) + else: + debug("Using DictDatabase") + from .dict import DictDatabase + return DictDatabase(SectionDict(_SESSION, "dict")) diff --git a/portato/db/dict.py b/portato/db/dict.py index 5c5ca49..d230821 100644 --- a/portato/db/dict.py +++ b/portato/db/dict.py @@ -24,9 +24,10 @@ class DictDatabase (Database): lock = Database.lock - def __init__ (self): + def __init__ (self, session): """Constructor.""" Database.__init__(self) + self.session = session self.__initialize() self.populate() diff --git a/portato/db/sql.py b/portato/db/sql.py index e7be91e..3cffd88 100644 --- a/portato/db/sql.py +++ b/portato/db/sql.py @@ -30,15 +30,22 @@ from .database import Database, PkgData class SQLDatabase (Database): + FORMAT = "1" FORBIDDEN = (".bzr", ".svn", ".git", "CVS", ".hg", "_darcs") lock = Database.lock - def __init__ (self): + def __init__ (self, session): """Constructor.""" Database.__init__(self) self._restrict = "" + self.session = session + updateFormat = False + if "format" not in session or session["format"] != self.FORMAT: + session["format"] = self.FORMAT + updateFormat = True + pkgdb = os.path.join(SESSION_DIR, "package.db") pkgdb_existed = os.path.exists(pkgdb) @@ -49,18 +56,22 @@ class SQLDatabase (Database): pkg_conn = sql.connect(os.path.join(SESSION_DIR, "package.db")) pkg_conn.row_factory = sql.Row + if pkgdb_existed and updateFormat: + pkg_conn.execute("DROP TABLE packages") + pkg_conn.execute(""" CREATE TABLE IF NOT EXISTS packages ( name TEXT, cat TEXT, - inst INTEGER + inst INTEGER, + disabled INTEGER )""") pkg_conn.commit() self.was_updated = self.updated() - if self.was_updated or not pkgdb_existed: + if self.was_updated or not pkgdb_existed or updateFormat: info(_("Cleaning database...")) pkg_conn.execute("DELETE FROM packages") # empty db at beginning info(_("Populating database...")) @@ -153,9 +164,9 @@ class SQLDatabase (Database): for p in system.find_packages(key = category, with_version = False): cat, pkg = p.split("/") - yield (cat, pkg, p in inst) + yield (cat, pkg, p in inst, False) - connection.executemany("INSERT INTO packages (cat, name, inst) VALUES (?, ?, ?)", _get()) + connection.executemany("INSERT INTO packages (cat, name, inst, disabled) VALUES (?, ?, ?, ?)", _get()) connection.commit() @lock -- cgit v1.2.3-54-g00ecf From d97a8bba4c3c877953bc6e800095ac4bc699ea45 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 11:29:08 +0100 Subject: Add the disabled field to PkgData --- portato/db/database.py | 14 +++++++++++--- portato/db/dict.py | 10 +++++++++- portato/db/sql.py | 18 ++++++++++-------- 3 files changed, 30 insertions(+), 12 deletions(-) (limited to 'portato') diff --git a/portato/db/database.py b/portato/db/database.py index 941c3a3..c36c5dc 100644 --- a/portato/db/database.py +++ b/portato/db/database.py @@ -16,15 +16,16 @@ from threading import RLock from functools import wraps class PkgData (object): - __slots__ = ("cat", "pkg", "inst") + __slots__ = ("cat", "pkg", "inst", "disabled") - def __init__ (self, cat, pkg, inst): + def __init__ (self, cat, pkg, inst = False, disabled = False): self.cat = cat self.pkg = pkg self.inst = inst + self.disabled = disabled def __iter__ (self): - return iter((self.cat, self.pkg, self.inst)) + return iter((self.cat, self.pkg, self.inst, self.disabled)) def __cmp__ (self, other): return cmp(self.pkg.lower(), other.pkg.lower()) @@ -80,6 +81,13 @@ class Database (object): """ raise NotImplentedError + def disable (self, cpv): + """Marks the CPV as disabled. + + @param cpv: the cpv to mark + """ + raise NotImplentedError + def reload (self, cat = None): """Reloads the given category. diff --git a/portato/db/dict.py b/portato/db/dict.py index d230821..422246f 100644 --- a/portato/db/dict.py +++ b/portato/db/dict.py @@ -51,7 +51,7 @@ class DictDatabase (Database): for p in packages: cat, pkg = p.split("/") inst = p in installed - t = PkgData(cat, pkg, inst) + t = PkgData(cat, pkg, inst, False) self._db[cat].append(t) self._db[self.ALL].append(t) @@ -124,6 +124,14 @@ class DictDatabase (Database): self.__initialize() self.populate() + @lock + def disable (self, cpv): + cat, pkg = cpv.split("/") + + c = self._db[cat] + p = c[c.find(PkgData(cat, pkg))] + p.disabled = True + def get_restrict (self): return self._restrict diff --git a/portato/db/sql.py b/portato/db/sql.py index 3cffd88..b406981 100644 --- a/portato/db/sql.py +++ b/portato/db/sql.py @@ -153,9 +153,8 @@ class SQLDatabase (Database): return f(*args, **kwargs) - return wrapper + return Database.lock(wrapper) - @lock @con def populate (self, category = None, connection = None): def _get(): @@ -169,7 +168,6 @@ class SQLDatabase (Database): connection.executemany("INSERT INTO packages (cat, name, inst, disabled) VALUES (?, ?, ?, ?)", _get()) connection.commit() - @lock @con def get_cat (self, category = None, byName = True, connection = None): sort = "ORDER BY name" @@ -177,15 +175,14 @@ class SQLDatabase (Database): sort = "ORDER BY inst DESC, name" if not category or category == self.ALL: - c = connection.execute("SELECT cat, name, inst FROM packages WHERE 1=1 %s %s" % (self.restrict, sort)) + c = connection.execute("SELECT cat, name, inst, disabled FROM packages WHERE 1=1 %s %s" % (self.restrict, sort)) else: - c = connection.execute("SELECT cat, name, inst FROM packages WHERE cat = ? %s %s" % (self.restrict ,sort), (category,)) + c = connection.execute("SELECT cat, name, inst, disabled FROM packages WHERE cat = ? %s %s" % (self.restrict ,sort), (category,)) for pkg in c: - yield PkgData(pkg["cat"], pkg["name"], pkg["inst"]) + yield PkgData(pkg["cat"], pkg["name"], pkg["inst"], pkg["disabled"]) c.close() - @lock @con def get_categories (self, installed = False, connection = None): @@ -205,7 +202,6 @@ class SQLDatabase (Database): for cat in l: yield cat["cat"] - @lock @con def reload (self, cat = None, connection = None): if cat: @@ -217,6 +213,12 @@ class SQLDatabase (Database): connection.commit() self.populate(connection = connection) + @con + def disable (self, cpv, connection = None): + cat, pkg = cpv.split("/") + connection.execute("UPDATE packages SET disabled = 1 WHERE cat = ? AND name = ?", (cat, pkg)) + connection.commit() + def get_restrict (self): return self._restrict -- cgit v1.2.3-54-g00ecf From 93ffd87b338c7107e3bc365392817390b6616f29 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 11:56:26 +0100 Subject: Add 'VersionsNotFoundException' --- portato/backend/exceptions.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'portato') diff --git a/portato/backend/exceptions.py b/portato/backend/exceptions.py index 37e9bda..46b2a3e 100644 --- a/portato/backend/exceptions.py +++ b/portato/backend/exceptions.py @@ -18,6 +18,10 @@ class PackageNotFoundException (Exception): """An exception marking that a package could not be found.""" pass +class VersionsNotFoundException (Exception): + """An exception marking that there could be no versions found for a specific CP.""" + pass + class DependencyCalcError (Exception): """An error occured during dependency calculation.""" pass -- cgit v1.2.3-54-g00ecf From f9fd4bbbe6778d27591c767c634e796a7054931e Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 12:05:33 +0100 Subject: Handle non existing versions --- portato/gui/dialogs.py | 7 +++++++ portato/gui/windows/main.py | 24 ++++++++++++++++++++---- 2 files changed, 27 insertions(+), 4 deletions(-) (limited to 'portato') diff --git a/portato/gui/dialogs.py b/portato/gui/dialogs.py index edf34b7..8931535 100644 --- a/portato/gui/dialogs.py +++ b/portato/gui/dialogs.py @@ -113,3 +113,10 @@ def prereq_error_dialog (e): ret = dialog.run() dialog.destroy() return ret + +def no_versions_dialog (cp): + dialog = gtk.MessageDialog(None, gtk.DIALOG_MODAL, gtk.MESSAGE_WARNING, gtk.BUTTONS_OK, _("No versions of package '%s' found!") % cp) + ret = dialog.run() + dialog.destroy() + return ret + diff --git a/portato/gui/windows/main.py b/portato/gui/windows/main.py index e51897f..472ddf0 100644 --- a/portato/gui/windows/main.py +++ b/portato/gui/windows/main.py @@ -28,7 +28,7 @@ from ...helper import debug, warning, error, info, unique_array from ...session import Session from ...db import Database from ...constants import CONFIG_LOCATION, VERSION, APP_ICON, ICON_DIR -from ...backend.exceptions import PackageNotFoundException, BlockedException +from ...backend.exceptions import PackageNotFoundException, BlockedException, VersionsNotFoundException # more GUI stuff from ..utils import Config, GtkThread, get_color @@ -38,7 +38,8 @@ from ..wrapper import GtkTree, GtkConsole from ..views import LogView, HighlightView, InstalledOnlyView, LazyStoreView from ..dialogs import (blocked_dialog, changed_flags_dialog, io_ex_dialog, nothing_found_dialog, queue_not_empty_dialog, remove_deps_dialog, - remove_queue_dialog, remove_updates_dialog, unmask_dialog) + remove_queue_dialog, remove_updates_dialog, unmask_dialog, + no_versions_dialog) from ..exceptions import PreReqError # even more GUI stuff @@ -745,7 +746,11 @@ class MainWindow (Window): store.clear() if name: - for cat, pkg, is_inst in self.db.get_cat(name, self.sortPkgListByName): + for cat, pkg, is_inst, disabled in self.db.get_cat(name, self.sortPkgListByName): + if disabled: + warning(_("Package '%s/%s' is disabled."), cat, pkg) + continue + if is_inst: icon = self.icons["installed"] elif not self.showAll: @@ -806,6 +811,8 @@ class MainWindow (Window): self.slotcol.set_visible(False) packages = system.sort_package_list(system.find_packages(cp, masked=True)) + if not packages: + raise VersionsNotFoundException(cp) # append versions for vers, inst, slot in ((x.get_version(), x.is_installed(), get_slot(x)) for x in packages): @@ -1336,8 +1343,17 @@ class MainWindow (Window): """ store, it = selection.get_selected() if it: + oldcp = self.selCP + self.selCP = "%s/%s" % (store.get_value(it, 2), store.get_value(it, 1)) - self.fill_version_list(self.selCP) + try: + self.fill_version_list(self.selCP) + except VersionsNotFoundException, e: + warning(_("No versions of package '%s' found!.") % self.selCP) + no_versions_dialog(self.selCP) + self.db.disable(self.selCP) + self.selCP = oldcp + return True def cb_pkg_list_header_clicked(self, col): -- cgit v1.2.3-54-g00ecf From 7d7cccefa1373570791bde516dd90f5055888481 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 12:26:31 +0100 Subject: find -> index --- portato/db/dict.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'portato') diff --git a/portato/db/dict.py b/portato/db/dict.py index 422246f..fd859dd 100644 --- a/portato/db/dict.py +++ b/portato/db/dict.py @@ -129,7 +129,7 @@ class DictDatabase (Database): cat, pkg = cpv.split("/") c = self._db[cat] - p = c[c.find(PkgData(cat, pkg))] + p = c[c.index(PkgData(cat, pkg))] p.disabled = True def get_restrict (self): -- cgit v1.2.3-54-g00ecf From a80ff9994c49b3aaba7d3f0bbf6317107fcf39bb Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 12:47:49 +0100 Subject: Do not show categories which only hold disabled packages --- portato/db/database.py | 4 +++- portato/db/dict.py | 7 +++++-- portato/db/sql.py | 12 ++++++++---- portato/gui/windows/main.py | 10 +++++----- 4 files changed, 21 insertions(+), 12 deletions(-) (limited to 'portato') diff --git a/portato/db/database.py b/portato/db/database.py index c36c5dc..bc78b01 100644 --- a/portato/db/database.py +++ b/portato/db/database.py @@ -59,13 +59,15 @@ class Database (object): """ raise NotImplentedError - def get_cat (self, cat = None, byName = True): + def get_cat (self, cat = None, byName = True, showDisabled = False): """Returns the packages in the category. @param cat: category to return the packages from; if None it defaults to C{ALL} @type cat: string @param byName: selects whether to return the list sorted by name or by installation @type byName: boolean + @param showDisabled: should disabled packages be returned + @type showDisabled: boolean @return: an iterator over the packages @rtype: L{PkgData} """ diff --git a/portato/db/dict.py b/portato/db/dict.py index fd859dd..d7e2649 100644 --- a/portato/db/dict.py +++ b/portato/db/dict.py @@ -62,17 +62,20 @@ class DictDatabase (Database): self._db[key].sort(key = self.__sort_key) @lock - def get_cat (self, cat = None, byName = True): + def get_cat (self, cat = None, byName = True, showDisabled = False): if not cat: cat = self.ALL def get_pkgs(): if byName: for pkg in self._db[cat]: - yield pkg + if showDisabled or not pkg.disabled: + yield pkg else: ninst = [] for pkg in self._db[cat]: + if not showDisabled and pkg.disabled: continue + if pkg.inst: yield pkg else: diff --git a/portato/db/sql.py b/portato/db/sql.py index b406981..cac5c97 100644 --- a/portato/db/sql.py +++ b/portato/db/sql.py @@ -169,15 +169,19 @@ class SQLDatabase (Database): connection.commit() @con - def get_cat (self, category = None, byName = True, connection = None): + def get_cat (self, category = None, byName = True, showDisabled = False, connection = None): sort = "ORDER BY name" if not byName: sort = "ORDER BY inst DESC, name" + disabled = "1=1" + if not showDisabled: + disabled = "disabled = 0" + if not category or category == self.ALL: - c = connection.execute("SELECT cat, name, inst, disabled FROM packages WHERE 1=1 %s %s" % (self.restrict, sort)) + c = connection.execute("SELECT cat, name, inst, disabled FROM packages WHERE %s %s %s" % (disabled, self.restrict, sort)) else: - c = connection.execute("SELECT cat, name, inst, disabled FROM packages WHERE cat = ? %s %s" % (self.restrict ,sort), (category,)) + c = connection.execute("SELECT cat, name, inst, disabled FROM packages WHERE cat = ? AND %s %s %s" % (disabled, self.restrict ,sort), (category,)) for pkg in c: yield PkgData(pkg["cat"], pkg["name"], pkg["inst"], pkg["disabled"]) @@ -191,7 +195,7 @@ class SQLDatabase (Database): else: where = "1 = 1" - c = connection.execute("SELECT cat FROM packages WHERE %s %s GROUP BY cat" % (where, self.restrict)) + c = connection.execute("SELECT cat FROM packages WHERE disabled = 0 AND %s %s GROUP BY cat" % (where, self.restrict)) l = c.fetchall() c.close() diff --git a/portato/gui/windows/main.py b/portato/gui/windows/main.py index 472ddf0..9f3c123 100644 --- a/portato/gui/windows/main.py +++ b/portato/gui/windows/main.py @@ -746,18 +746,18 @@ class MainWindow (Window): store.clear() if name: - for cat, pkg, is_inst, disabled in self.db.get_cat(name, self.sortPkgListByName): - if disabled: - warning(_("Package '%s/%s' is disabled."), cat, pkg) + for pkg in self.db.get_cat(name, self.sortPkgListByName): + if pkg.disabled: + warning(_("Package '%s/%s' is disabled."), pkg.cat, pkg.pkg) continue - if is_inst: + if pkg.inst: icon = self.icons["installed"] elif not self.showAll: continue # ignore not installed packages else: icon = None - store.append([icon, pkg, cat]) + store.append([icon, pkg.pkg, pkg.cat]) def build_version_list (self): store = gtk.ListStore(gtk.gdk.Pixbuf, str, str) -- cgit v1.2.3-54-g00ecf From e3a7f1a2120f6bd20bdaf53afab5a5de1ae25554 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 13:10:26 +0100 Subject: Remove the USE_SQL flag - use normal config instead --- portato/constants.py | 3 --- portato/db/__init__.py | 25 +++++++++++++++++++------ 2 files changed, 19 insertions(+), 9 deletions(-) (limited to 'portato') diff --git a/portato/constants.py b/portato/constants.py index 79ad0f2..3d7217f 100644 --- a/portato/constants.py +++ b/portato/constants.py @@ -22,8 +22,6 @@ These should be set during the installation. @type HOME: string @var SU_COMMAND: command to execute to "su" @type SU_COMMAND: string -@var USE_SQL: whether to use the sqlite db -@type USE_SQL: boolean @var CONFIG_DIR: The configuration directory. @type CONFIG_DIR: string @@ -58,7 +56,6 @@ APP = "portato" VERSION = "9999" HOME = os.environ["HOME"] SU_COMMAND = "gksu -D 'Portato'" -USE_SQL = True # config CONFIG_DIR = "/etc/portato/" diff --git a/portato/db/__init__.py b/portato/db/__init__.py index 40bf9ee..d77fc0d 100644 --- a/portato/db/__init__.py +++ b/portato/db/__init__.py @@ -13,22 +13,35 @@ from __future__ import absolute_import from ..session import Session, SectionDict -from ..constants import USE_SQL from ..helper import debug _SESSION = None +_TYPE = None + +def _set_type(t): + global _TYPE + _TYPE = t def Database(): - global _SESSION + global _SESSION, _TYPE if _SESSION is None: _SESSION = Session("db.cfg", name = "DB") + _SESSION.add_handler((["type"], _set_type, lambda: _TYPE), default = ["sql"]) + _SESSION.load() - if USE_SQL: + if _TYPE == "sql": debug("Using SQLDatabase") - from .sql import SQLDatabase - return SQLDatabase(SectionDict(_SESSION, "SQL")) - else: + try: + from .sql import SQLDatabase + except ImportError: + debug("Cannot load SQLDatabase.") + _TYPE = "dict" + return Database() + else: + return SQLDatabase(SectionDict(_SESSION, "SQL")) + + elif _TYPE == "dict": debug("Using DictDatabase") from .dict import DictDatabase return DictDatabase(SectionDict(_SESSION, "dict")) -- cgit v1.2.3-54-g00ecf From cffc4dbc7529d761600bcaf5fbc63bdb308b3194 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 2 Feb 2009 13:24:40 +0100 Subject: Use warning instead of debug, if the sql database could not be loaded --- portato/db/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'portato') diff --git a/portato/db/__init__.py b/portato/db/__init__.py index d77fc0d..e0919dd 100644 --- a/portato/db/__init__.py +++ b/portato/db/__init__.py @@ -13,7 +13,7 @@ from __future__ import absolute_import from ..session import Session, SectionDict -from ..helper import debug +from ..helper import debug, warning _SESSION = None _TYPE = None @@ -35,7 +35,7 @@ def Database(): try: from .sql import SQLDatabase except ImportError: - debug("Cannot load SQLDatabase.") + warning(_("Cannot load SQLDatabase.")) _TYPE = "dict" return Database() else: -- cgit v1.2.3-54-g00ecf From eab7389888eb97ddcdf174acce717f45157ed079 Mon Sep 17 00:00:00 2001 From: René 'Necoro' Neumann Date: Mon, 9 Feb 2009 13:26:28 +0100 Subject: SQLDatabase.populate needs a regexp --- portato/db/sql.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'portato') diff --git a/portato/db/sql.py b/portato/db/sql.py index cac5c97..b46374e 100644 --- a/portato/db/sql.py +++ b/portato/db/sql.py @@ -211,7 +211,7 @@ class SQLDatabase (Database): if cat: connection.execute("DELETE FROM packages WHERE cat = ?", (cat,)) connection.commit() - self.populate(cat+"/", connection = connection) + self.populate(cat+"/*", connection = connection) else: connection.execute("DELETE FROM packages") connection.commit() -- cgit v1.2.3-54-g00ecf