aboutsummaryrefslogtreecommitdiff
path: root/internal/feed
diff options
context:
space:
mode:
authorRené 'Necoro' Neumann <necoro@necoro.eu>2024-02-29 10:38:13 +0100
committerRené 'Necoro' Neumann <necoro@necoro.eu>2024-02-29 10:38:13 +0100
commit0833f21bb79425d090fe9830bc6ea6fc9a065f4b (patch)
tree6a093efcf8e5e5dbb7dbc00e7502d9f90b98c0ab /internal/feed
parent66fd13c76f787a63f252146c0bb70546c1c0380a (diff)
downloadfeed2imap-go-0833f21bb79425d090fe9830bc6ea6fc9a065f4b.tar.gz
feed2imap-go-0833f21bb79425d090fe9830bc6ea6fc9a065f4b.tar.bz2
feed2imap-go-0833f21bb79425d090fe9830bc6ea6fc9a065f4b.zip
Pass -1 instead of nil to avoid having an int*
Diffstat (limited to 'internal/feed')
-rw-r--r--internal/feed/cache/v1.go18
1 files changed, 9 insertions, 9 deletions
diff --git a/internal/feed/cache/v1.go b/internal/feed/cache/v1.go
index 4e3f3e2..8091b28 100644
--- a/internal/feed/cache/v1.go
+++ b/internal/feed/cache/v1.go
@@ -277,14 +277,14 @@ func (cf *cachedFeed) Filter(items []feed.Item, ignoreHash, alwaysNew bool) []fe
filtered := make([]feed.Item, 0, len(items))
cacheadd := make([]cachedItem, 0, len(items))
- app := func(item *feed.Item, ci cachedItem, oldIdx *int) {
- if oldIdx != nil {
+ app := func(item *feed.Item, ci cachedItem, oldIdx int) {
+ if oldIdx > -1 {
item.UpdateOnly = true
- prevId := cf.Items[*oldIdx].ID
+ prevId := cf.Items[oldIdx].ID
ci.ID = prevId
item.ID = prevId
- log.Debugf("oldIdx: %d, prevId: %s, item.id: %s", *oldIdx, prevId, item.Id())
- cf.markItemDeleted(*oldIdx)
+ log.Debugf("oldIdx: %d, prevId: %s, item.id: %s", oldIdx, prevId, item.Id())
+ cf.markItemDeleted(oldIdx)
}
filtered = append(filtered, *item)
cacheadd = append(cacheadd, ci)
@@ -306,7 +306,7 @@ CACHE_ITEMS:
log.Debugf("Guid matches with: %s", oldItem)
if !oldItem.similarTo(&ci, ignoreHash) {
item.AddReason("guid (upd)")
- app(item, ci, &idx)
+ app(item, ci, idx)
} else {
log.Debugf("Similar, ignoring item %s", base64.RawURLEncoding.EncodeToString(oldItem.ID[:]))
seen(idx)
@@ -318,7 +318,7 @@ CACHE_ITEMS:
log.Debug("Found no matching GUID, including.")
item.AddReason("guid")
- app(item, ci, nil)
+ app(item, ci, -1)
continue
}
@@ -337,7 +337,7 @@ CACHE_ITEMS:
}
log.Debugf("Link matches, updating: %s", oldItem)
item.AddReason("link (upd)")
- app(item, ci, &idx)
+ app(item, ci, idx)
continue CACHE_ITEMS
}
@@ -345,7 +345,7 @@ CACHE_ITEMS:
log.Debugf("No match found, inserting.")
item.AddReason("new")
- app(item, ci, nil)
+ app(item, ci, -1)
}
log.Debugf("%d items after filtering", len(filtered))